Skip to content

Hide settings button if not on development mode#5431

Merged
yadvr merged 3 commits into
apache:4.15from
shapeblue:fixsettingsdevmode
Sep 10, 2021
Merged

Hide settings button if not on development mode#5431
yadvr merged 3 commits into
apache:4.15from
shapeblue:fixsettingsdevmode

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez commented Sep 10, 2021 •
edited
Loading

Description

This PR displays the Settings widget only in development mode
Screenshot from 2021-09-10 09-51-19

After the fix in production:
Screenshot from 2021-09-10 09-49-53

After the fix in development:
Screenshot from 2021-09-10 09-51-19

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Sep 10, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5431 (SL-JID-627)

@nvazquez nvazquez marked this pull request as ready for review September 10, 2021 12:20
shwstppr
shwstppr approved these changes Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on QA server, looks good to me!

@shwstppr shwstppr requested a review from utchoang September 10, 2021 12:22
@yadvr yadvr added this to the 4.15.2.0 milestone Sep 10, 2021
@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Sep 10, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5431 (SL-JID-628)

@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Sep 10, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5431 (SL-JID-629)

@nvazquez nvazquez changed the title Display colors Save settings only in dev mode Hide settings button if not on development mode Sep 10, 2021
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 10, 2021

Tested lgtm

shwstppr
shwstppr approved these changes Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to not show settings button in current form. @utchoang maybe we can relook this in 4.16? Currently, it doesn't save settings in any way, not even for a single session.
LGTM

@yadvr yadvr merged commit 35efdd1 into apache:4.15 Sep 10, 2021
@nvazquez nvazquez deleted the fixsettingsdevmode branch February 12, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@shwstppr shwstppr shwstppr approved these changes

@utchoang utchoang Awaiting requested review from utchoang

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.15.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nvazquez @blueorangutan @yadvr @shwstppr